Revert "Revert "Merge pull request #1806 from firebase/nc/quickstarts"" #1815
Conversation
Summary of ChangesHello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a revert, effectively reapplying the changes from an earlier pull request. It focuses on renaming targets within the project, updating scheme files, and removing a legacy project to streamline the codebase and project structure. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous revert, effectively re-applying a large set of modernization and cleanup changes across several quickstart examples. The key changes include the removal of legacy Objective-C and older Swift projects, a migration from Cocoapods to Swift Package Manager for dependency management, and a general cleanup of project, target, and scheme names for better consistency. Additionally, the codebase is updated with modern Swift features, such as using @main for the app entry point and @MainActor for UI-related code to ensure thread safety. A notable improvement is the replacement of a third-party reachability library with Apple's native Network framework in the Crashlytics example. Overall, these changes significantly improve the structure, maintainability, and modernity of the quickstart projects.
|
Will approve once I finish migrating snippets and update devsite references. There was more legacy stuff than I expected so I'm a bit behind, but hope to be done today. |
|
@morganchen12, no problem. I'll merge on your signal. |
2 participants
Reverts #1811